Twiink commented on code in PR #45671:
URL: https://github.com/apache/superset/pull/45671#discussion_r4366127939
##########
superset/utils/date_parser.py:
##########
@@ -846,8 +845,13 @@ def eval(self) -> datetime:
month=1, day=1, hour=0, minute=0, second=0, microsecond=0
)
if unit == "quarter":
- dttm = (
- pd.Period(pd.Timestamp(dttm),
freq="Q").to_timestamp().to_pydatetime()
+ dttm = dttm.replace(
Review Comment:
Thanks for catching this regression. Fixed in 45b0f5b: mixed aware/naive
bounds explicitly use legacy wall-clock ordering for validation while retaining
offsets in the returned bounds. Fully aware bounds still compare by instant.
The saved quarter : now example works again, including inherited
time-comparison durations. Added regression tests for both mixed-bound
directions and reversed ranges. All 215 targeted and adjacent tests pass
locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
