sadpandajoe commented on code in PR #45604: URL: https://github.com/apache/superset/pull/45604#discussion_r4369367353
########## superset-frontend/src/dashboard/components/ColorSchemeSelect.test.tsx: ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + render, + screen, + userEvent, + waitFor, +} from 'spec/helpers/testing-library'; +import ColorSchemeSelect from './ColorSchemeSelect'; + +const openAndGetPopup = async () => { + await userEvent.click( + screen.getByRole('combobox', { name: 'Select color scheme' }), + ); + await waitFor(() => + expect(document.querySelector('.ant-select-dropdown')).toBeInTheDocument(), + ); + return document.querySelector('.ant-select-dropdown') as HTMLElement; +}; + +test('portals the palette inside the enclosing modal container', async () => { + render( + <div className="ant-modal-container" data-test="modal"> + <ColorSchemeSelect onChange={jest.fn()} /> + </div>, + ); + const popup = await openAndGetPopup(); + expect(screen.getByTestId('modal').contains(popup)).toBe(true); +}); + +test('portals the palette to document.body outside a modal', async () => { + render( + <div data-test="wrapper"> + <ColorSchemeSelect onChange={jest.fn()} /> + </div>, + ); + const popup = await openAndGetPopup(); + expect(screen.getByTestId('wrapper').contains(popup)).toBe(false); + expect(document.body.contains(popup)).toBe(true); Review Comment: The grouped-option padding and font rules were moved onto the popup root class here, but neither new test looks at them: both only check where the popup lands. If the `classNames.popup.root` block in `ColorSchemeSelect` were dropped while the container callback stayed, both tests would still pass and the group headings and grouped options would silently lose their styling in the dashboard properties modal. The explore and word-cloud controls each got a test for this, but this component has its own copy. Could you register a grouped scheme set and assert the popup root carries an emotion class whose stylesheet rule targets `.ant-select-item-option-grouped`, as in the explore `ColorSchemeControl` test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
