Madan015 commented on issue #45332: URL: https://github.com/apache/superset/issues/45332#issuecomment-6399841026
Working in the same team as @jchong9. Small update to this proposal after looking closer at the code: **Excel:** instead of a ZIP with a separate filters workbook, Excel exports will get an extra "Filters" worksheet at the end of the same workbook. It keeps the filters in the same file as the data, matches the original idea in #44864, and means Excel exports keep the file type they have today (no changes to the dashboard download flow). So the Excel values are now `none` and `inline`, and `separate` is CSV only. **No filters applied:** if the user asks for filter metadata and no filters apply, the export will still include the metadata header with a line saying "No filters were applied", instead of leaving it out. That way the recipient can tell that filters were checked and none applied. **Custom SQL filters:** filters written as custom SQL by the chart's author will be listed with their SQL text, since they change the data like any other filter. SQL generated by Superset and row-level security rules are still left out. **Formula safety:** every metadata cell will go through the existing formula escaping (`escape_value` for CSV, the existing formula check for Excel), per @rusackas's note. **Exports built in the browser:** Pivoted Excel and Export Current View are built in the browser, which can't make a ZIP without a new dependency. Their CSV exports will offer only the first two options. **Very large CSVs:** CSVs of 100,000 rows or more are streamed and can't be zipped, so "Include filters as a separate file" will be greyed out for them. If the backend only decides to stream after the user picked it, the filters are written as comment lines instead. **Filters we can't check:** for dashboard charts exported as images, and CSVs that are streamed from the start, no query runs that could tell us which filters were applied. In those cases every filter on the chart is listed. **PRs:** three instead of two: 1. chart CSV export support 2. chart Excel and browser-built exports 3. dashboard Excel export support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
