CodeWithPravinMaske commented on code in PR #45619: URL: https://github.com/apache/superset/pull/45619#discussion_r4371150515
########## superset-frontend/src/utils/isImageOnlyExportViz.ts: ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { VizType } from '@superset-ui/core'; + +// A KPI card shows one final number: it has no table of data worth exporting, and a PDF +// of it is the same picture as the PNG. These charts offer image exports only. +const IMAGE_ONLY_EXPORT_VIZ_TYPES: string[] = [ + VizType.BigNumber, Review Comment: You're right: big_number is Big Number with Trendline and its query returns the daily series, so it should keep CSV/Excel. Image-only is now limited to big_number_total and pop_kpi, and there is a test that the trendline chart keeps its data exports. ########## superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/useExploreAdditionalActionsMenu.test.tsx: ########## @@ -520,3 +520,29 @@ test('Export All Data JPEG screenshot passes addWarningToast to downloadAsImage' mockAddWarningToast, ); }); + +test('A Big Number chart keeps only the image exports in Data Export Options', async () => { + render( + <TestComponent + {...defaultProps} + latestQueryFormData={{ + datasource: '1__table', + viz_type: 'big_number_total', + }} + />, + { + useRedux: true, + initialState: { explore: { can_export_image: true } }, + }, + ); + + await userEvent.hover(await screen.findByText('Data Export Options')); + await userEvent.hover(await screen.findByText('Export All Data')); Review Comment: Added a test that opens Export Current View for a Big Number fixture and asserts that only the screenshot items remain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
