codeant-ai-for-open-source[bot] commented on code in PR #42620:
URL: https://github.com/apache/superset/pull/42620#discussion_r4372080660
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -424,7 +470,14 @@ export const SaveDatasetModal = ({
const filterAutocompleteOption = (
inputValue: string,
option: DatasetOverwriteOption,
- ) => option.value.toLowerCase().includes(inputValue.toLowerCase());
+ ) => {
+ const label = option.label.toLowerCase();
+ // Position-independent: a dataset may or may not have a catalog, and a
+ // search skipping a part (`examples.sales`) should still match.
+ return parseQualifiedSearch(inputValue.toLowerCase()).parts.every(part =>
+ label.includes(part),
+ );
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> In SaveDatasetModal dataset overwrite filtering, allow qualified search
components to match regardless of position so searches can skip the catalog; do
not require components to match positional order.
**Applied to:**
- `superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -342,9 +385,19 @@ export const SaveDatasetModal = ({
endpoint: `/api/v1/dataset/?q=${queryParams}`,
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `e6b27e3`.
The loader accepts `page` and `pageSize` and includes them as `page` and
`page_size` in the dataset API query.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
