I3eka opened a new pull request, #45719:
URL: https://github.com/apache/superset/pull/45719

   ## SUMMARY
   
   Completed Native AI turns stream provider-supplied thinking but omit 
`thoughts` from the persisted assistant message. Reloading the conversation 
therefore loses the thought process. Include `result.thoughts` in the existing 
successful finalization payload, including an empty value when the provider did 
not supply it.
   
   > **ON HOLD — Draft pending SIP-224.** This change depends on the proposed 
Native AI assistant in https://github.com/apache/superset/pull/42805. Please do 
not merge until https://github.com/apache/superset/issues/42806 is accepted and 
the parent implementation is ready.
   
   This branch includes the shared Native AI compatibility base updated to 
Apache master. The focused fix is commit `ab37cec4f4`; it does not change 
provider behavior or manufacture reasoning from answer text.
   
   ## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Persistence change: after a completed turn, reloading retains the provider 
thinking already shown during streaming.
   
   ## TESTING INSTRUCTIONS
   
   - Regression tests fail before the fix because the finalization payload 
lacks `thoughts`.
   - `pytest --confcutdir=tests/unit_tests -q 
tests/unit_tests/ai/test_runtime.py tests/unit_tests/ai/test_orchestrator.py`: 
62 passed.
   - Branch-file pre-commit checks passed, including mypy, pylint and frontend 
type checking.
   - Uses the scripted provider; no external model or deployment was involved.
   
   ## ADDITIONAL INFORMATION
   
   - [x] Has associated issue: SIP-224 / #42806 (parent dependency).
   - [ ] Required feature flags: existing `AI_ASSISTANT`; no new flag.
   - [ ] Breaking changes: none in this focused fix.
   - [ ] New database migrations: none in the focused fix. The shared parent 
compatibility base includes the merge revision joining the AI and upstream 
migration heads.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to