sadpandajoe opened a new pull request, #45724:
URL: https://github.com/apache/superset/pull/45724
### SUMMARY
`npm run plugins:build` (the `tsc` step of lint-frontend, and `release.yml`)
fails on master with `lerna ERR! EFILTER No packages remain after filtering [
'{@superset-ui/!(demo|generator-superset),@apache-superset/*}\n' ]`.
The babel `lerna exec` template literal in
`superset-frontend/scripts/build.js` breaks the line right after `--scope
${scope}`, and `run()` splits the command on spaces only, so lerna receives the
scope with a trailing newline. That newline has been there since #17552; lerna
10.0.1 matched with minimatch 3, which tolerated it. #45715 (lerna `^10.0.1` ->
`^10.1.1`) moved lerna to minimatch 10, which does not, so no package matches.
This ends the line with a backslash so the template literal continues
without a newline, as the `tsc` call a few lines below already does. The
composed babel commands are otherwise unchanged.
### TESTING INSTRUCTIONS
1. `cd superset-frontend && npm ci --include=dev`
2. `npm run plugins:build`
3. Before: the first babel pass exits with `EFILTER`. After: the `lerna
notice filter including` lines show no `\n`, and the babel lib, babel esm and
tsc passes each run across the 21 packages.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
