I3eka opened a new pull request, #45729: URL: https://github.com/apache/superset/pull/45729
## Problem and change `MssqlEngineSpec` inherited the no-op cancellation methods, so execution owners could not obtain a cancellation handle or stop an active SQL Server query through Superset's engine contract. Capture `@@SPID` before execution and issue `KILL` over the caller's separate cancellation connection. Validate the handle before interpolation and end only the cancellation connection's transaction, because SQL Server forbids `KILL` inside a user transaction. Return false and log a cancellation failure. Azure Synapse and Sybase retain their previous unsupported behavior rather than inheriting SQL Server's protocol. Document the required warehouse permissions (`ALTER ANY CONNECTION` / Azure SQL Database's `KILL DATABASE CONNECTION`) and session termination/rollback behavior. This is an engine fix independent of Native AI and does not change or grant warehouse permissions. ## Validation - 84 SQL Server and cancellation-validation unit tests pass, including ID capture, fresh-cursor commands, invalid handles, permission failure, and subclass compatibility. - All changed-file pre-commit hooks pass, including mypy, pylint and engine metadata validation. - No live SQL Server cancellation was performed; no deployment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
