mikebridge opened a new pull request, #45745:
URL: https://github.com/apache/superset/pull/45745
A dashboard version preview now shows a clear placeholder for an archived or
unavailable chart while the other charts continue to render.
### SUMMARY
Explore can return a successful response without chart metadata for a chart
in an older dashboard version. Preview previously treated it as a chart,
showing “Untitled chart” and a validation error. The preview now keeps that
chart out of hydration and replaces its saved tile with a localized markdown
placeholder. The version-history guide and translation template include the new
copy.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: the affected tile shows “Untitled chart” and a raw validation error.
After: the tile explains that the chart is archived or unavailable and directs
editors to Recently Archived. Screenshot capture is pending a deployment with a
dashboard version containing an archived chart.
### TESTING INSTRUCTIONS
1. Enable `VERSION_HISTORY` and `SOFT_DELETE`, save a dashboard version
containing at least two charts, then archive one chart.
2. Preview the older dashboard version. Confirm that the archived tile shows
the placeholder and the other chart renders normally.
3. Close preview and confirm the live dashboard is restored.
4. Run the focused version-history Jest suites and
`scripts/translations/check_pot_drift.py`.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Required feature flags: `VERSION_HISTORY` and `SOFT_DELETE` for the
manual archive scenario
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
