mikebridge opened a new pull request, #45747:
URL: https://github.com/apache/superset/pull/45747
Archive links stay available until dismissed, dependency warnings show
accurate totals, and Recently Archived follows browser history consistently.
Keyboard users can read why an action is unavailable, and recovery links work
under a URL prefix.
**Stacked on #45476.** This branch includes #45476's commits until that PR
merges. Review only the last six commits: one per behavior change, plus a
docs/test cleanup.
### SUMMARY
Follow-ups from a product-acceptance pass over #45476:
1. **Link toasts stay open.** Toasts that carry a link ("View in Recently
Archived") stay open until they're dismissed, instead of timing out while the
pointer or keyboard focus is on them. Plain-text toasts keep their timers.
2. **Accurate dataset counts.** The bulk dataset archive warning counts
charts and dashboards separately, e.g. "linked to 4 charts and 1 dashboard",
instead of implying every chart is on a dashboard.
3. **History navigation.** ListView replays sort along with page and filters
from the URL. Recently Archived pushes type changes into history, so Back and
Forward return to the previous page, sort, search and type.
4. **Keyboard access to disabled actions.** The disabled Edit and
Archive/Delete items in chart and dashboard card menus get focusable tooltip
wrappers, so keyboard users can read why an action is unavailable. The items
themselves stay disabled.
5. **Recovery link under a URL prefix.** The recovery toast's "View
Dashboard" link keeps the application root prefix.
Not included: an explicit "this dataset is archived" message in Explore. It
needs a server-provided reason, so it'll be a separate change.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Behavior and copy changes. Screenshots to follow.
### TESTING INSTRUCTIONS
- Archive a chart, hover or tab to the toast's link: the toast stays until
dismissed.
- Archive several datasets where some charts are on no dashboard: the counts
are separate and accurate.
- In Recently Archived, change page, sort, search and type, then use Back
and Forward: each state is restored.
- Tab through a card menu where Edit or Archive is unavailable: the reason
tooltip appears on focus.
- Under a URL prefix (e.g. `/analytics`), recover a dashboard: the toast
link opens it.
- Jest: toast, ListView state and component, ArchivedList, and the chart and
dashboard card suites (130 tests).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Required feature flags: `SOFT_DELETE`
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
