rusackas commented on code in PR #45749:
URL: https://github.com/apache/superset/pull/45749#discussion_r4384049565
##########
.github/labeler.yml:
##########
@@ -181,3 +181,45 @@
- any-glob-to-any-file:
- '.github/actions/**'
- '.github/workflows/**'
+
+############################################
+# Hold labels - these block merge (see
+# .github/workflows/no-hold-label.yml) until a maintainer who's reviewed
+# the change removes the label. Path-triggered, replacing what used to be
+# CODEOWNERS-required review for the same paths.
+############################################
+
+"hold:audit-gha":
+- changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
Review Comment:
This PR leaves CODEOWNERS alone on purpose, so nothing is relying on the
label alone yet. The labeler/hold-check ordering is something to sort out in
the follow-up that deletes those entries, not a gap here, since CODEOWNERS
still gates merge in the meantime.
##########
.github/labeler.yml:
##########
@@ -181,3 +181,45 @@
- any-glob-to-any-file:
- '.github/actions/**'
- '.github/workflows/**'
+
+############################################
+# Hold labels - these block merge (see
+# .github/workflows/no-hold-label.yml) until a maintainer who's reviewed
+# the change removes the label. Path-triggered, replacing what used to be
+# CODEOWNERS-required review for the same paths.
+############################################
+
+"hold:audit-gha":
+- changed-files:
+ - any-glob-to-any-file:
+ - '.github/**'
+
+"hold:audit-scripts":
+- changed-files:
+ - any-glob-to-any-file:
+ - 'scripts/**'
Review Comment:
Same here, this only applies once CODEOWNERS is gone, which is a separate
PR. The loosening (anyone with write access can clear the label) is a tradeoff
I called out in the description, and ASF write access is already limited to
vetted committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
