rusackas commented on code in PR #43695:
URL: https://github.com/apache/superset/pull/43695#discussion_r4384088652
##########
superset/db_engine_specs/databricks.py:
##########
@@ -1147,6 +1220,17 @@ class DatabricksODBCEngineSpec(DatabricksBaseEngineSpec):
"database": "Database name",
"http_path": "HTTP path from SQL endpoint settings",
},
+ "known_incompatibilities": [
+ {
+ "dependency": "SQLAlchemy 2.0",
+ "reason": (
+ "databricks-dbapi pins sqlalchemy>=1.3,<2.0; no SQLAlchemy
2.0 "
+ "support is planned for the legacy driver. Use the
Databricks "
+ "Python Connector (databricks-sql-connector) instead."
+ ),
+ "tracking_url":
"https://github.com/databricks/databricks-dbapi";,
Review Comment:
Dead link, confirmed via PyPI's project metadata for `databricks-dbapi` -
this is the real repo.
```suggestion
"tracking_url":
"https://github.com/crflynn/databricks-dbapi";,
```
##########
superset/db_engine_specs/databricks.py:
##########
@@ -1191,6 +1275,17 @@ class
DatabricksHiveEngineSpec(SparkSqlBooleanEqualityMixin, HiveEngineSpec):
"database": "Database name",
"http_path": "HTTP path from cluster settings",
},
+ "known_incompatibilities": [
+ {
+ "dependency": "SQLAlchemy 2.0",
+ "reason": (
+ "databricks-dbapi pins sqlalchemy>=1.3,<2.0; no SQLAlchemy
2.0 "
+ "support is planned for the legacy driver. Use the
Databricks "
+ "Python Connector (databricks-sql-connector) instead."
+ ),
+ "tracking_url":
"https://github.com/databricks/databricks-dbapi";,
Review Comment:
Same dead link as the ODBC spec above.
```suggestion
"tracking_url":
"https://github.com/crflynn/databricks-dbapi";,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
