I3eka commented on PR #45561: URL: https://github.com/apache/superset/pull/45561#issuecomment-6431451573
Merged Apache master `1220ec01ef85` into this branch without rewriting history; the published head is `c8c079654469`. Rechecked all 14 inline findings and the additional cases in @rebenitez1802's review. The existing fixes preserve accepted Stop outcomes, keep cache failures from changing a successful query to failed, recover an inactive metadata session, retain recorded end times, and finalize MCP deadline failures before propagating them. I replied in each inline thread with the specific result. The four annotation warnings are false positives; a fresh-process import verifies the existing postponed annotations. Validation on this head: **778 SQL execution tests passed, 3 skipped; 62 MCP worker/pool tests passed; all applicable pre-commit checks passed**. The worker tests use the default in-memory SQLite setup. My first run used file-backed SQLite, which changed the pool type and invalidated one test's no-waiting-pool assumption; the corrected full worker run passes. New-head GitHub CI is still running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
