I3eka commented on PR #43135: URL: https://github.com/apache/superset/pull/43135#issuecomment-6433144592
Updated this branch through `568aea93ed` with Apache master `1220ec01ef` included. All nineteen inline findings have a current fix or revalidation reply. For the [earlier review summary](https://github.com/apache/superset/pull/43135#issuecomment-5647735954): history is bounded to the accepted turn, concrete model pins reach the provider, unread streams expire, checkpoints are per run, cancellation verifies the owned thread/run association, and broker replays still execute once. Reloaded conversations follow their stored result, and duplicate consumers preserve the original cancellation flag. Parent callbacks handle child worker loss/hard timeout; complete parent/host loss remains explicitly outside that callback guarantee. Local validation on this head: **785 backend tests, 115 frontend tests and all applicable hooks for 120 PR files pass**. The migration graph has one head. The new history, reload and helper-directive regressions fail on their respective pre-fix code. The description records the test scope and remaining limits. This remains **Draft / ON HOLD** behind #42805 and SIP #42806. No deployment was performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
