I3eka commented on PR #45730: URL: https://github.com/apache/superset/pull/45730#issuecomment-6434942818
Updated to `0a01dc9851` after merging Apache master `1220ec01ef85` and the safe live-cursor cancellation prerequisite from #45729. The review refresh contains no inline/human findings. While verifying the deadline contract raised in #43133, I reproduced five gaps: stalled completion/stream reads, loss of the timeout across separate synchronous pulls, and failure to use explicitly supported live-cursor cancellation. Those cases now pass. Provider retry delays share the same remaining budget, partial answer text is preserved, and a provider's own TimeoutError is not relabelled as run-budget expiry. 1,563 relevant unit tests passed, 3 skipped; all hooks for 128 PR files pass. Real provider/warehouse cancellation was not exercised. The description retains cooperative cancellation/network-timeout limits rather than claiming a hard bound for arbitrary drivers. The title now reflects both provider and SQL deadlines. This remains Draft / ON HOLD behind #42805 and SIP #42806. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
