I3eka commented on PR #45569: URL: https://github.com/apache/superset/pull/45569#issuecomment-6434783687
Updated to `1f8d896aa0` with Apache master `1220ec01ef85`. The review refresh found no inline or human findings. I rechecked the timestamp behavior against `AuditMixinNullable`, which stores server-local naive dates; converting them to explicit UTC preserves the instant without a fixed five-hour correction. All five API cases pass. Validation did find a separate compatibility defect: two Alembic heads. The existing regression failed before the new no-op join and passes afterwards. An isolated SQLite probe confirms upgrade from either parent and downgrade of the join, preserving schema and sentinel data. 701 AI backend tests, 105 frontend tests and all hooks for 119 PR files pass; the migration-head regression also passes after the fix. The Codecov report includes the unmerged AI base, so its coverage gaps should not be read as a reproduced timestamp error. No deployment or new browser check is claimed. This remains Draft / ON HOLD behind #42805 and SIP #42806. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
