rusackas opened a new pull request, #45772: URL: https://github.com/apache/superset/pull/45772
### SUMMARY `PinotEngineSpec.column_datatype_to_string` special-cased `TIMESTAMP` columns because older `pinotdb` releases compiled them as `NUMERIC` instead of `TIMESTAMP` (the `TypeCompiler`'s `visit_TIMESTAMP` was wrongly aliased to `visit_NUMERIC`). The override's own comment named the exact upstream fix to watch for: `startreedata/pinot-dbapi#224`. That PR merged 2026-10-07 and shipped in `pinotdb` 9.2.1 (`visit_TIMESTAMP` now aliases to `visit_DATETIME`). A dependabot bump (`00688c7871b`, 2026-10-21) already raised this repo's `pinotdb[sqlalchemy]` floor to `9.2.2` for an unrelated reason, without anyone noticing the override had become dead code — verified directly against the installed `pinotdb` 9.2.1/9.2.2 wheels (`visit_TIMESTAMP = visit_DATETIME`) vs. 9.2.0 (still `visit_TIMESTAMP = visit_NUMERIC`). This PR: - Removes the now-unused `column_datatype_to_string` override and its now-dead imports (`sqlalchemy.types`, `Dialect`, `TypeEngine`). - Updates the `pinot` extra's `version_requirements` doc string to state the real floor (`>=9.2.1`) and explain both historical reasons for it (SQLAlchemy 2 support below 8.0.0, the TIMESTAMP bug below 9.2.1), since it still referenced the stale `>=8.0.0` floor. - Adds a regression test (`test_column_datatype_to_string_timestamp`) against the real installed `pinotdb` dialect, so a future `pinotdb` version bump that somehow regresses this gets caught instead of silently reintroducing the bug this override used to paper over. No behavior change for any current install: `pinotdb>=9.2.1` already compiles `TIMESTAMP` correctly on its own, so `column_datatype_to_string(TIMESTAMP(), dialect)` returns `"TIMESTAMP"` either way. ### TESTING INSTRUCTIONS ``` pytest tests/unit_tests/db_engine_specs/test_pinot.py -v ``` All 11 tests pass, including the new `test_column_datatype_to_string_timestamp`. `pre-commit run` is clean on both changed files. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
