codeant-ai-for-open-source[bot] commented on code in PR #45793:
URL: https://github.com/apache/superset/pull/45793#discussion_r4391697260
##########
superset/db_engine_specs/clickhouse.py:
##########
@@ -154,6 +165,11 @@ def is_read_limit_error(cls, ex: Exception) -> bool:
}
column_type_mappings = (
+ (
+ re.compile(r"^AggregateFunction\b", re.IGNORECASE),
+ AggregateFunctionState(),
+ GenericDataType.NUMERIC,
+ ),
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> For ClickHouse AggregateFunction state type mappings, do not claim that
the generic type changes filter behavior: raw states are rejected in WHERE
regardless. Limit concerns to metadata and type presentation for nonnumeric
states.
**Applied to:**
- `superset/db_engine_specs/clickhouse.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
