rusackas commented on PR #45768: URL: https://github.com/apache/superset/pull/45768#issuecomment-6452114339
Closing this one. On a second look, the duplication wasn't really worth centralizing: eight of the nine sites already carry their own string default via `request.args.get(key, "false")`, so `is_truthy_str` was mostly just renaming `x.lower() == "true"` rather than removing real duplication. Also checked whether the `.lower()` itself was covering some inconsistency worth fixing, and it's not. The frontend sends `shared=true` lowercase, literally hardcoded, so an exact `"True"` match would break that caller. `databend.py`'s `secure` param needs to stay case-insensitive for connections stored under the legacy driver, which parsed it with `asbool()`. Nothing to consolidate there either. Leaving the original inline checks as they were. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
