EkVid opened a new pull request, #487: URL: https://github.com/apache/superset-kubernetes-operator/pull/487
## Summary Adds a top-level `spec.logLevel` (`debug`, `info`, `warning`, `error`, `critical`; runtime default `info`) inherited by every component and lifecycle task, with a per-component `logLevel` and a single `lifecycle.logLevel` that override it. The operator maps the resolved level onto each component's own mechanism. **This is a draft to get feedback on the core design and logics before the remaining pieces are added.** Part of #453 ## Details **Design notes** - The rendered config is the same at every level, so a level change doesn't change `ConfigHash` or init's `EnvHash`, so lifecycle tasks won't be triggered again. - The level isn't in the shared config checksum, each component's level only reaches its own pod template. - No k8s default on any `logLevel`, `info` is applied at resolution. **Breaking:** `webServer.gunicorn.logLevel` is removed because of`webServer.logLevel`. **Upgrade effect:** every rendered `superset_config.py` gains the `LOG_LEVEL` line, so upgrading the operator rolls every component once and runs init once. **Not in this draft yet (will be added from other teammates)** - Flower (`FLOWER_LOGGING`), MCP server (`FASTMCP_LOG_LEVEL`) and websocket server (`LOG_LEVEL`). - The `DebugLogging` condition and Warning Event for `debug` outside Development. - New unit and envtest tests, including the two checksum behaviors. Existing tests are adjusted to pass due to the removed Gunicorn field. - User docs and release notes. The Gunicorn section of `configuration.md` still lists `logLevel` until then. - More as needed **Verification:** `make codegen` (no diff), `make lint-go`, `make lint-md`, and the unit and envtest suites pass. The plans were checked by hand on Kind before implementing, but a thorough (end to end) Kind run of this branch still needs to be done. I'd appreciate your feedback on the core implementation and the plan for the remaining work before we move on. I've tried to follow the project's commenting style, but please let me know if anything should be adjusted. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
