FrancescoCastaldi commented on PR #44945:
URL: https://github.com/apache/superset/pull/44945#issuecomment-6468974201
### Summary of Updates & Resolution
In commit `e6e69a36a1`, we addressed all review feedback from @sadpandajoe
and rebased cleanly onto latest `upstream/master`:
1. **Elimination of Duplicate `onChange` Dispatches (#44921)**:
- Removed `onChange(val)` from `Radio.Button`'s `onClick` handler,
preserving solely `e.currentTarget?.focus()`.
- Option selection events are now handled exclusively by
`Radio.Group.onChange`, dispatching exactly once per change.
- Clicking an already-selected option is a clean no-op, resolving the
second symptom described in #44921.
2. **Prop Cleanup**:
- Removed the unused `initialValue` prop from `RadioButtonControlProps`
and its redundant test cases.
3. **Rebase & Unit Test Verification**:
- Rebased cleanly on top of `upstream/master` (resolving the dirty merge
state, now `MERGEABLE`).
- Updated `RadioButtonControl.test.tsx` to assert exact single call
counts (`toHaveBeenCalledTimes(1)`), multiple distinct clicks
(`toHaveBeenCalledTimes(3)`), and verified that clicking an already selected
option does not trigger `onChange`.
- Validated locally with `oxlint` (0 errors) and TypeScript compiler `tsc
--noEmit` (0 errors).
@sadpandajoe, all points raised have been addressed and the PR is ready for
your re-review whenever convenient. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
