schizophrenicmaniac commented on PR #45220: URL: https://github.com/apache/superset/pull/45220#issuecomment-6468633990
@itzmzn following up on EnxDev's note: #45235 makes the same `dashboardState.ts` change as this PR, so it'd be good if only one of them goes in. This one keeps to the source-dashboard write, and EnxDev agreed above to leave the cross-filter chart id remapping for a separate PR. Your PR already does that remapping in `DashboardDAO`, so how about narrowing #45235 to it once this lands? Happy to go the other way if the maintainers prefer yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
