SEPURI-SAI-KRISHNA commented on PR #45822: URL: https://github.com/apache/superset/pull/45822#issuecomment-6475275496
Heads up, #45461 has been open for this since Oct 19 and is linked on the issue. It covers the same four parse sites: `get_since_until_from_query_object` in `processing_time_offsets`, the date-range offset parse, the temporal filter rewrite in that loop, and the one in `get_sqla_query`. The only difference I can see is where the date-range offset is caught. You widen the inner `except` beside the call, mine widens the outer one that encloses it. Same effect, since that call is the only parse inside the outer try. No preference on which lands, just flagging so we don't both carry it. The reversed-range test asked for on mine went in Oct 25, so it isn't blocked on my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
