codeant-ai-for-open-source[bot] commented on code in PR #45827:
URL: https://github.com/apache/superset/pull/45827#discussion_r4405728069
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.tsx:
##########
@@ -441,26 +441,20 @@ function ExploreViewContainer(props:
ExploreViewContainerProps) {
const theme = useTheme();
- // Capture original title before any effects run
- const originalTitle = useMemo(() => document.title, []);
-
// Update document title when slice name changes
useEffect(() => {
if (props.sliceName) {
document.title = sanitizeDocumentTitle(props.sliceName);
}
}, [props.sliceName]);
- // Restore original title on unmount
+ // Restore the app title on unmount. The title at mount is not a usable
+ // fallback: a direct page load already has the server-rendered name in it.
useEffect(
() => () => {
- document.title =
- originalTitle ||
- theme?.brandAppName ||
- theme?.brandLogoAlt ||
- 'Superset';
+ document.title = theme?.brandAppName || theme?.brandLogoAlt ||
'Superset';
Review Comment:
**Suggestion:** If either brand token contains control characters, this
unmount assignment puts them in `document.title`, which can hang or crash
headless browsers.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Possible bug`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c67e3a9b5a8549ecb42b81ab0b548767&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c67e3a9b5a8549ecb42b81ab0b548767&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
**Line:** 455:455
**Comment:**
*Possible Bug: If either brand token contains control characters, this
unmount assignment puts them in `document.title`, which can hang or crash
headless browsers.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45827&comment_hash=774c553e14355f73c15a0d65bbfd84edfc1254aa10b8c1a618e43fab55b5040b&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45827&comment_hash=774c553e14355f73c15a0d65bbfd84edfc1254aa10b8c1a618e43fab55b5040b&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
