aminghadersohi commented on PR #45799: URL: https://github.com/apache/superset/pull/45799#issuecomment-6458446334
Product acceptance at 51eb49a45aeb1a5f8cd2c2c7ab2e5c31d71f28eb: **ship**. I ran the PR head and the merge base (e97d7cac645c817e9b9c0daebabcbb9b0802cde9) in a real Superset with Postgres and the MCP service, calling the tools over streamable HTTP through the default `search_tools` / `call_tool` proxy, with six saved charts. - `generate_dashboard`: `""`, `" "`, `"\t\n"`, omitted and `None`, through `dashboard_title`, `title` and `name`. On head, 9/9 save the same chart-derived title (`Revenue by Region, Orders over Time, Product Mix + 3 more`), as Admin, Alpha and Gamma (with dataset access). On the merge base, the three `""` cases stored an empty title: the dashboard list shows it blank and the dashboard page title falls back to "Superset". - Nonblank titles are unchanged (`Q3 Sales & Ops`), and `<script></script>` is still rejected. - `update_dashboard` and `duplicate_dashboard` still reject blank values for all three aliases with `request.dashboard_title: Text must not be empty`. The stored title never changed. - Chart names behave the same as on the merge base: a blank name on `generate_chart` gets a generated name. On `update_chart`, a blank name-only rename is rejected, and a config update keeps the saved name. One LOW finding, outside this diff and also present on the merge base. A blank name-only `update_chart` returns "Either 'config', 'add_columns', 'chart_name', or 'dataset_id' must be provided." even though `chart_name` was passed, and the message has no field location. Nothing blank is written. Not verified: natural-language prompts through a real LLM (I called the tools directly), and JWT auth (I used fixed-user dev mode). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
