sadpandajoe commented on code in PR #45508: URL: https://github.com/apache/superset/pull/45508#discussion_r4397454249
########## superset/migrations/versions/2026-10-19_00-00_7b9d2f8a6c31_add_teams_installations.py: ########## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Add Teams bot installation persistence. + +Revision ID: 7b9d2f8a6c31 +Revises: 3740c7bcb2c6 +""" + +import sqlalchemy as sa +from alembic import op +from sqlalchemy.dialects import mysql +from sqlalchemy_utils import UUIDType + +from superset.migrations.shared.utils import create_table + +revision: str = "7b9d2f8a6c31" +down_revision: str = "3740c7bcb2c6" Review Comment: `f72b6e9c104a` (`add_oauth2_token_management_indexes`) already on master also has `down_revision = "3740c7bcb2c6"`, so with this parent the merged tree has two Alembic heads and `superset db upgrade` fails with a multiple-heads error, whether or not Teams is enabled. Should this be re-parented onto `f72b6e9c104a` (and the revision file name/date kept after it)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
