mikebridge commented on code in PR #45554:
URL: https://github.com/apache/superset/pull/45554#discussion_r4407242699
##########
superset/semantic_layers/api.py:
##########
@@ -338,13 +345,12 @@ def structure(self, pk: int) -> Response:
]
except SupersetSecurityException as ex:
return self.response(403, message=ex.message,
errors=[ex.to_dict()])
- except Exception: # pylint: disable=broad-except
- logger.exception(
- "Error fetching structure for semantic view %d",
- pk,
- )
+ except Exception as ex: # pylint: disable=broad-except
+ log_provider_failure("Error fetching semantic view structure", ex)
Review Comment:
Agreed. In `4cd9e5c053`, `log_provider_failure` takes the view `pk` and
layer UUID, and all three call sites pass them, so the message now reads e.g.
`Error fetching semantic view structure view_id=12 layer_uuid=…`. Only stored
identifiers are logged, never provider or configuration text. The
configuration-schema preview has no saved view or layer, so it logs them as
`None` rather than taking anything from the submitted JSON. Tests check that
each message names the IDs and still contains no credential-like values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
