betodealmeida opened a new pull request #8854: Add toast presenter to Welcome 
app
URL: https://github.com/apache/incubator-superset/pull/8854
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   The toast presenter is missing from the welcome app, so toasts are never 
displayed. I noticed this while investigating another problem.
   
   I also improved the error message when the dashboard endpoint returns a 401.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   Now:
   
   ![Screen Shot 2019-12-17 at 11 31 57 
AM](https://user-images.githubusercontent.com/1534870/71027824-e0782000-20c0-11ea-98bc-2d32f1d0d0fb.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Tested locally.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @khtruong @nytai 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to