Re: [PR] fix(sqllab): reject duplicate saved query names [superset]

via GitHub Wed, 28 Oct 2026 19:55:56 -0700


codeant-ai-for-open-source[bot] commented on code in PR #45795:
URL: https://github.com/apache/superset/pull/45795#discussion_r4405313638



##########
superset-frontend/src/SqlLab/actions/sqlLab.ts:
##########
@@ -1214,15 +1237,16 @@ export function updateSavedQuery(
       .then(() => {
         dispatch(addSuccessToast(t('Your query was updated')));
         dispatch(queryEditorSetTitle(query, query.name ?? '', clientId));
+        dispatch(updateQueryEditor(query));

Review Comment:
   **Suggestion:** When the same saved query is open in multiple tabs, the 
reducer updates the first editor with this remote ID, which can overwrite 
another tab’s SQL and description.
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Incorrect 
variable usage`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e6532eb66fc4485f9f3a8348e147cf28&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e6532eb66fc4485f9f3a8348e147cf28&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/SqlLab/actions/sqlLab.ts
   **Line:** 1240:1240
   **Comment:**
        *Incorrect Variable Usage: When the same saved query is open in 
multiple tabs, the reducer updates the first editor with this remote ID, which 
can overwrite another tab’s SQL and description.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45795&comment_hash=63a61cf4e5f9c071bd554eac47ae945d3053a13a9aa1cc3aa1b8cbfeb7936e12&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45795&comment_hash=63a61cf4e5f9c071bd554eac47ae945d3053a13a9aa1cc3aa1b8cbfeb7936e12&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(sqllab): reject duplicate saved query names [superset]

Reply via email to