amaannawab923 commented on code in PR #45522:
URL: https://github.com/apache/superset/pull/45522#discussion_r4401311682
##########
superset-core/src/superset_core/extensions/types.py:
##########
@@ -77,6 +153,10 @@ class BaseExtension(BaseModel):
default_factory=list,
description="Permissions required by this extension",
)
+ contributions: Contributions = Field(
+ default_factory=Contributions,
+ description="What this extension contributes to the host",
+ )
Review Comment:
Holds, with a milder symptom than described, and fixed in c34e681.
The visit does not end at a bare "Page not found": the route serves the
shell, the client finds no registered page, and `ExtensionPage` renders its own
explanation once extensions have settled. So it is a confusing manifest rather
than a broken request. But the underlying point stands -- a page is half a
contribution, the manifest declaring the path and the bundle supplying the
component, and with no frontend there is no remote entry, so nothing can ever
register one.
They are now refused at registration, as a set rather than per path, since
the cause is the manifest and not any individual page. Registering them anyway
would put entries in the nav that resolve to nothing.
Refused rather than rejected at parse time, to match how the other page
guards behave here: a bad page is skipped and logged, never fatal to the
extension or to the boot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
