Aleem89 commented on code in PR #45648: URL: https://github.com/apache/superset/pull/45648#discussion_r4408500080
########## superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/TimeseriesLegendIcon.tsx: ########## @@ -0,0 +1,208 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { styled, useTheme } from '@apache-superset/core/theme'; +import type { + TimeseriesLegendIcon as TimeseriesLegendIconData, + TimeseriesLegendLineType, +} from './types'; + +// ECharts legend defaults: itemWidth 25, itemHeight 14, and a line icon's +// symbol at 80% of the item height. +const WIDTH = 25; +const HEIGHT = 14; +const HOLLOW_STROKE_WIDTH = 2; + +const round = (value: number) => Math.round(value * 100) / 100; + +const LINE_SYMBOL_SIZE = round(HEIGHT * 0.8); + +// Same expansion zrender applies to a dashed or dotted line of this width. +function getDashArray( + lineType: TimeseriesLegendLineType, + lineWidth: number, +): string | undefined { + if (lineType === 'dashed') { + return `${4 * lineWidth} ${2 * lineWidth}`; + } + if (lineType === 'dotted') { + return `${lineWidth}`; + } + return Array.isArray(lineType) ? lineType.join(' ') : undefined; +} + +type PaintProps = { + fill: string; + stroke?: string; + strokeWidth?: number; +}; + +function Symbol({ Review Comment: Thanks for the review, Enzo! Good call on this, went ahead and renamed it to LegendSymbol in 81bbbe9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
