villebro commented on issue #8684: Fix hana time filter URL: https://github.com/apache/incubator-superset/pull/8684#issuecomment-566733727 I feel the comments raised in the original PR still stands. To be able to merge this PR, I would like to see the following: - some official documentation or similar stating that dates expressed as strings with format `YYYYMMDD` are more common in SAP/HANA, than, say, `YYYY-MM-DD` or just plain dates. - Any comments meant for end users should be placed in `docs/installation.rst` rather than as comments in the code base.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
