rusackas commented on code in PR #45588: URL: https://github.com/apache/superset/pull/45588#discussion_r4408961320
########## .github/workflows/update-country-maps.yml: ########## @@ -0,0 +1,189 @@ +name: Update Country Maps + +# Regenerates plugins/plugin-chart-country-map's GeoJSON files, countries.ts +# and docs/data/countries.json from upstream Natural Earth + community geo +# data, by running the same notebook `npm run update-maps` runs locally. +# +# Runs weekly and on workflow_dispatch, but only opens or updates a PR when +# the regenerated output actually differs from what's on `master` - most +# weeks this is a no-op. Unlike a translation-string catch-up, nothing here +# auto-merges: a border/region change is the kind of thing that needs an +# actual human look at the rendered maps. Community geo sources are pinned +# to a commit where practical; the live WHO ArcGIS query can't be pinned +# (it's a live service, not a repo), so a run can still legitimately pick up +# an unreviewed upstream change there. The job itself fails (separately from +# whether a PR was opened) if the notebook hits a cell error, so a broken +# upstream source doesn't just quietly go green. +on: + schedule: + - cron: "0 7 * * 1" # Mondays 07:00 UTC, an hour after sync-translation-catalogs.yml Review Comment: Good question, and honestly no real reason. They don't share any state, apache/superset's public so Actions minutes aren't scarce, and each workflow has its own concurrency group so they can't block each other either way. The offset was mostly to keep two unrelated bot PRs from landing in the queue at the same minute, which probably isn't worth protecting. Open to staggering them for real if you think it's worth it, or keeping some kind of record of all the scheduled jobs and when they run somewhere - not sure where that'd live though. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
