jansule commented on code in PR #39760:
URL: https://github.com/apache/superset/pull/39760#discussion_r4412015990
##########
superset-frontend/plugins/plugin-chart-cartodiagram/src/plugin/transformProps.ts:
##########
@@ -17,44 +17,63 @@
* under the License.
*/
import { ChartProps, getChartTransformPropsRegistry } from '@superset-ui/core';
-import {
- getChartConfigs,
- parseSelectedChart,
-} from '../util/transformPropsUtil';
+import { getChartConfigs, parseSelectedChart } from
'../util/transformPropsUtil';
+import { ChartConfig } from '../types';
export default function transformProps(chartProps: ChartProps) {
const { width, height, formData, hooks, theme } = chartProps;
const {
geomColumn,
+ geomFormat,
selectedChart: selectedChartString,
chartSize,
layerConfigs,
+ mapExtentPadding,
+ mapMaxExtent,
Review Comment:
The defaults are also being applied in dashboards, so existing charts will
not crash when this code will be merged. See also
https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/actions/dashboardState.ts#L947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
