gabotorresruiz commented on code in PR #45558:
URL: https://github.com/apache/superset/pull/45558#discussion_r4416386672
##########
UPDATING.md:
##########
@@ -24,6 +24,12 @@ assists people when migrating to a new version.
## Next
+- Refreshing a dataset's columns from its source (the "Sync columns from
+ source" button, or `PUT /api/v1/dataset/<id>?override_columns=true`) no
+ longer resets **Is dimension** and **Is filterable** on existing columns.
+ Newly discovered columns still arrive with both enabled; a deployment that
+ relied on a resync to restore those defaults must set them explicitly.
Review Comment:
Small one: should `PUT /api/v1/dataset/<id>/refresh` be listed here too? It
runs the same `fetch_metadata` through `RefreshDatasetCommand`, so it is
probably what a deployment scripting a resync is calling.
```suggestion
- Refreshing a dataset's columns from its source (the "Sync columns from
source" button, `PUT /api/v1/dataset/<id>?override_columns=true`, or
`PUT /api/v1/dataset/<id>/refresh`) no longer resets **Is dimension** and
**Is filterable** on existing columns. Newly discovered columns still
arrive
with both enabled; a deployment that relied on a resync to restore those
defaults must set them explicitly.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
