seunggabi commented on issue #44512: URL: https://github.com/apache/superset/issues/44512#issuecomment-6509383212
Thanks @rusackas and @sfirke — agreed on all three points: 1. **Config, not a feature flag.** I'll move `REQUIRE_DOWNLOAD_REASON` out of `FEATURE_FLAGS` into a regular config key (default off), and expose it to the frontend through the bootstrap config. 2. **Action Log only**, no new table — unchanged. 3. **Centralized / DRY.** I'll keep the "ask for a reason" prompt and the server-side check in one shared helper so other reason-gated actions can reuse it later, rather than adding per-call-site logic. I'll push these changes to #44499 (also freshly merged with master, mergeable again) and then open the [VOTE] thread on dev@ once they're in, so the vote is on the final shape. The Oct 28 date I mentioned has passed without a vote on purpose for this reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
