seunggabi commented on PR #44499: URL: https://github.com/apache/superset/pull/44499#issuecomment-6510618301
Pushed the change agreed on the SIP (#44512): `REQUIRE_DOWNLOAD_REASON` is now a plain config setting (default `False`), no longer a feature flag. - `config.py`: moved out of `DEFAULT_FEATURE_FLAGS` into a regular key; exposed to the browser through `FRONTEND_CONF_KEYS` (bootstrap `common.conf`). - One shared backend helper, `is_download_reason_required()` in `superset/utils/download_reason.py`, is now the only place that reads it — both the request check and the scheduled-report URL builder use it. - Frontend: `isDownloadReasonRequired()` (the single gate every export path already goes through) reads `common.conf`; the `FeatureFlag.RequireDownloadReason` enum member is gone. - Tests, `UPDATING.md`, `feature-flags.json` and the OpenAPI descriptions updated accordingly. Reasons are still only recorded in the existing Action Log (no new table). CI is running on the new commit. @rusackas @sfirke — does this match what you had in mind? Once CI is green I'll open the [VOTE] thread on dev@. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
