aminghadersohi commented on PR #45874: URL: https://github.com/apache/superset/pull/45874#issuecomment-6517464691
Acceptance run at 8990688ef63f0cae2f7b39df719042752ffc8b5e: real Superset app in-process, a real SQLite metadata DB, real requests through the Flask test client. The same script ran at the merge-base (4e6d03bf99223e82cd6b5c4c8a3ba806dc24cb83) and at head. - `PUT /api/v1/database/<id>` rename after the datasets were loaded in the same session: at the merge-base, 2 of 4 charts (the dataset with a schema) keep the old `perm`, and a viewer with only the dataset grant gets 404 on 2 of 4 `GET /api/v1/chart/<id>/data/` calls. At head all 4 charts have the new `perm`/`schema_perm` and all 4 calls return 200. A user without the grant still gets 404 on all 4. - `/api/v1/assets/import/` of a bundle whose dataset has a new table name and schema: at the merge-base the charts keep the old `perm`/`schema_perm`. At head they match the dataset. - Rename from a fresh session, and `PUT /api/v1/dataset/<id>` table rename: same result at both commits (same permission names, 241 -> 241 permission-view rows, no duplicates, no new warnings). - Semantic layer: `tests/unit_tests/semantic_layers/models_test.py` and `tests/unit_tests/security/` pass at head (871 tests). The new rename test fails at the merge-base. Pre-existing and not changed by this PR (the body already says so): an asset import that renames a database leaves the old database name in `schema_perm` of its datasets and charts. A role granted `schema_access` on the new name gets 404 on those charts, at both commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
