Abhi2939 commented on issue #45877: URL: https://github.com/apache/superset/issues/45877#issuecomment-6524183783
Thanks @FrancescoCastaldi. Are you planning to open a PR from that branch? I have a concern with step 2: falling back to user.username in QueryObject.cache_key would apply to all datasource types and wouldn’t reflect role changes or the guest handling discussed in the issue. It may be cleaner to keep the change inside SemanticView.get_extra_cache_keys, as proposed. Would a maintainer weigh in on the preferred approach before anyone opens a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
