rusackas commented on issue #8857: Removing some dividers to make header 
dropdown menus more consistent
URL: 
https://github.com/apache/incubator-superset/pull/8857#issuecomment-566898391
 
 
   > Does this still render everything properly when you have the Druid REST 
Connector active?
   
   Well, that depends on what we call "proper" I guess :)
   
   As it stands, this PR removes the horizontal rules:
   
![image](https://user-images.githubusercontent.com/812905/71063542-bf93e700-2121-11ea-9aaf-158ff6f5e18c.png)
   
   But since Druid adds four menu options, I could see the argument to add one 
in above the Druid-items like so:
   
![image](https://user-images.githubusercontent.com/812905/71063461-996e4700-2121-11ea-8a93-d3124b9a2d88.png)
   
   Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to