joe-clickhouse commented on PR #45739: URL: https://github.com/apache/superset/pull/45739#issuecomment-6530315710
Reviewed from the ClickHouse side and it looks good. - Reproduced the collision on 26.8 with both analyzers. The unique suffix returns the correct top 3 in both. - No change needed in clickhouse-connect. The fix keeps ClickHouse's default alias-first resolution, which the dialect's GROUP BY rendering depends on. - For master, a follow-up should qualify the ON column with the `series_limit` alias. That removes the ambiguity and matches how the group-others path already references the subquery. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
