codeant-ai-for-open-source[bot] commented on code in PR #45908: URL: https://github.com/apache/superset/pull/45908#discussion_r4428603596
########## superset-frontend/plugins/plugin-chart-echarts/src/Sankey/crossFilter.ts: ########## @@ -0,0 +1,358 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { GenericDataType } from '@apache-superset/core/common'; +import { + DataRecordValue, + getColumnLabel, + getTimeFormatter, + QueryFormColumn, + QueryObjectFilterClause, +} from '@superset-ui/core'; +import { NULL_STRING } from '../constants'; +import { formatSeriesName } from '../utils/series'; + +/** + * Display text for an empty string. Matches `optionLabel` in + * `src/utils/common.ts`; this plugin cannot import that module. + */ +export const EMPTY_STRING = '<empty string>'; + +export type SankeyFilterColumn = 'source' | 'target'; + +/** Fields ECharts keeps on a node and returns from a click. */ +export type SankeyNodeDatum = { + name: string; + filterColumn: SankeyFilterColumn; + rawValue: DataRecordValue; +}; + +/** Fields ECharts keeps on a link and returns from a click. */ +export type SankeyLinkDatum = { + source: string; + target: string; + value: number; + sourceValue: DataRecordValue; + targetValue: DataRecordValue; +}; + +type NamedLink = { + source: string; + target: string; +}; + +type ParsedSelection = + | { kind: 'node'; column: SankeyFilterColumn; name: string } + | { kind: 'link'; source: string; target: string }; + +/** + * Label used as the ECharts node name. `null` and `''` stay distinct so a + * click can emit `IS NULL` or `IN ['']`. + */ +export function sankeyNodeName(value: DataRecordValue): string { + if (value == null) { + return NULL_STRING; + } + if (typeof value === 'bigint') { + return value.toString(); + } + const text = String(value); + return text === '' ? EMPTY_STRING : text; Review Comment: **Suggestion:** `String`-based names merge distinct values such as `42n` and `42`, or `null` and a string equal to `NULL_STRING`; the node map keeps only the first raw value, making the other unselectable. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Logic error` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=328f4822a12848b7812ae051dde6c402&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=328f4822a12848b7812ae051dde6c402&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/plugins/plugin-chart-echarts/src/Sankey/crossFilter.ts **Line:** 68:75 **Comment:** *Logic Error: `String`-based names merge distinct values such as `42n` and `42`, or `null` and a string equal to `NULL_STRING`; the node map keeps only the first raw value, making the other unselectable. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45908&comment_hash=b9a70b62d01494a4dd53f85fca070ef89f9b933c7602847e784d3ba7e72147e8&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45908&comment_hash=b9a70b62d01494a4dd53f85fca070ef89f9b933c7602847e784d3ba7e72147e8&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
