dhruv-techdev commented on code in PR #45858:
URL: https://github.com/apache/superset/pull/45858#discussion_r4428889163
##########
superset/db_engine_specs/oracle.py:
##########
@@ -190,7 +190,7 @@ def get_column_types(
TimeGrain.MINUTE: "TRUNC(CAST({col} as DATE), 'MI')",
TimeGrain.HOUR: "TRUNC(CAST({col} as DATE), 'HH')",
TimeGrain.DAY: "TRUNC(CAST({col} as DATE), 'DDD')",
- TimeGrain.WEEK: "TRUNC(CAST({col} as DATE), 'WW')",
+ TimeGrain.WEEK: "TRUNC(CAST({col} as DATE), 'IW')",
Review Comment:
Thanks for the thorough review, and for verifying `'D'` on a live Impala!
Added your entry to the `## Next` section of `UPDATING.md` in cd1ed69f01,
and merged the latest `master` to resolve the conflict with the other new
entries there. I also restored the full PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
