rusackas commented on PR #45589:
URL: https://github.com/apache/superset/pull/45589#issuecomment-6537039454
Quick update for anyone waiting on the updated demo video.
While putting together a Playwright recording covering all three tabs
(Favorite/Mine/All) for both Dashboards and Charts, one run appeared to show a
dashboard's Recents entry surviving 15+ seconds after deleting it from the Mine
tab - which would have meant this fix doesn't actually work in that case. That
capture environment had accumulated a lot of cruft (orphaned processes, a
possibly-stale webpack bundle), so before touching any code I ran a
from-scratch repro instead: fresh SQLite DB, fresh migrations, fresh backend +
webpack dev server, nothing left over from prior runs. It could not reproduce
the staleness - the Recents entry disappeared immediately on every tab, for
both dashboards and charts.
That matches what the code shows: `LogDAO.get_recent_activity` correctly
excludes soft-deleted items, the `/recent_activity/` response carries no
caching headers, and `onActivityRefresh` fires regardless of which tab
triggered the delete. So the original capture's staleness looks like an
artifact of that environment, not a real bug.
To make sure this stays pinned down, I added
`playwright/tests/home/recent-activity-refresh.spec.ts`, covering all six
combinations of {Favorite, Mine, All} x {Dashboards, Charts}. All six pass
cleanly against a clean environment.
Still finishing up a cleaner demo video (readable fixture names instead of
the long IDs in the current one) - will post it here once it's ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
