EnxDev commented on code in PR #45520:
URL: https://github.com/apache/superset/pull/45520#discussion_r4431273654
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.test.tsx:
##########
@@ -1562,3 +1562,72 @@ test('drillBy uses the swapped data index for a
horizontal time-based axis', asy
},
]);
});
+
+const makeVerticalLegend = (
+ orientation: LegendOrientation.Left | LegendOrientation.Right,
Review Comment:
This is the tsc failure in lint-frontend (TS2345 at line 1588). The
`test.each([LegendOrientation.Left, LegendOrientation.Right])` below infers
plain `LegendOrientation`, which doesn't fit this narrowed parameter.
The object gets cast to `never` anyway, so widening the parameter is the
smallest fix:
```suggestion
orientation: LegendOrientation,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
