EnxDev commented on code in PR #45865:
URL: https://github.com/apache/superset/pull/45865#discussion_r4431281791
##########
superset/utils/pandas_postprocessing/boxplot.py:
##########
@@ -103,6 +103,11 @@ def whisker_low(series: Series) -> float:
whisker_high = np.max
whisker_low = np.min
+ def count(series: Series) -> int:
Review Comment:
Nit, take it or leave it. `NUMPY_FUNCTIONS["count"]` in
`pandas_postprocessing/utils.py:35` is still `np.ma.count`, so an `aggregate`
or `pivot` step with `operator: "count"` keeps counting NULL rows the same way.
Same swap would fix it there too. Fine as a follow-up if you'd rather keep
this PR tight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
