EnxDev commented on issue #45082: URL: https://github.com/apache/superset/issues/45082#issuecomment-6541881928
@FrancescoCastaldi `rename.py` isn't where this happens. `rename` on master already rejects a mapping that would create a duplicate label (`Label already exists`). The duplicate comes from `_append_columns` in `utils.py`, which `cum`, `diff`, `rolling` and the geography operations go through, and #45083 fixes it there with tests. Dropping the existing column before renaming would also turn an invalid request into silent data loss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
