codeant-ai-for-open-source[bot] commented on code in PR #45894:
URL: https://github.com/apache/superset/pull/45894#discussion_r4431983813
##########
superset-frontend/src/middleware/asyncEvent.ts:
##########
@@ -653,6 +653,7 @@ export const waitForAsyncData = async <T = unknown[]>(
if (signal?.aborted || generation !== pollingGeneration) {
throw new DOMException('Aborted', 'AbortError');
}
+ if (queryError.errors?.length) throw { errors: queryError.errors };
Review Comment:
**Suggestion:** `waitForAsyncData` is also used by self-contained charts,
whose error handler drops this objectโs `errors`; OAuth failures there become
generic errors without an authorization prompt.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1b5c5ec0ddb841679113cdeca9896731&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1b5c5ec0ddb841679113cdeca9896731&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/middleware/asyncEvent.ts
**Line:** 656:656
**Comment:**
*Api Mismatch: `waitForAsyncData` is also used by self-contained
charts, whose error handler drops this objectโs `errors`; OAuth failures there
become generic errors without an authorization prompt.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45894&comment_hash=c370f9a951c376a96afa41aa849c6c9a5f557565a37c0f7c5004d9d79084f842&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45894&comment_hash=c370f9a951c376a96afa41aa849c6c9a5f557565a37c0f7c5004d9d79084f842&reaction=dislike'>๐</a>
##########
superset-frontend/src/features/semanticLayers/SemanticLayerModal.tsx:
##########
@@ -480,7 +571,11 @@ export default function SemanticLayerModal({
saveDisabled={
isTypeStep
? !selectedType
- : saving || clearing || !name.trim() || hasErrors
+ : saving ||
+ clearing ||
+ !name.trim() ||
+ hasErrors ||
+ requiredActionPending
Review Comment:
**Suggestion:** `refreshingSchema` is omitted here, so Save remains enabled
during dependent-schema discovery and can persist configuration before its
dynamic fields are reconciled.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incorrect
condition logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=da46241f961242e2839fde1092d695d7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=da46241f961242e2839fde1092d695d7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/features/semanticLayers/SemanticLayerModal.tsx
**Line:** 574:578
**Comment:**
*Incorrect Condition Logic: `refreshingSchema` is omitted here, so Save
remains enabled during dependent-schema discovery and can persist configuration
before its dynamic fields are reconciled.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45894&comment_hash=99d944859c11537a938003002448553c7a569c9c79d1da9ff735bd48843a9dbe&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45894&comment_hash=99d944859c11537a938003002448553c7a569c9c79d1da9ff735bd48843a9dbe&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
