codeant-ai-for-open-source[bot] commented on code in PR #45929:
URL: https://github.com/apache/superset/pull/45929#discussion_r4432971103
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -1329,6 +1335,24 @@ function DatasourceEditor({
});
}, []);
+ // The partition mapping capability and its transform pre-fill belong to the
+ // engine, and arrive on the dataset payload for the database it was loaded
+ // with. Pointing the dataset at another database has to re-derive both from
+ // the selected database's engine, or the editor keeps offering (or keeps
+ // hiding) partition mapping according to the engine it just left.
+ const onDatabaseChange = useCallback((db: DatabaseObject | undefined) => {
+ if (db === undefined) return;
+ setDatasource(prev => ({
+ ...prev,
+ database: db,
+ supports_partition_filter_mapping: Boolean(
+ db.supports_partition_filter_mapping,
+ ),
+ partition_value_transform_default:
+ db.partition_value_transform_default ?? null,
+ }));
Review Comment:
**Suggestion:** Switching databases retains the old `catalog`, `schema`, and
physical `table_name` through `...prev`; saving can target stale objects in the
newly selected database.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Stale reference`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3ac99bf1ab9842fcb8007bc374ed64aa&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3ac99bf1ab9842fcb8007bc374ed64aa&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
**Line:** 1345:1353
**Comment:**
*Stale Reference: Switching databases retains the old `catalog`,
`schema`, and physical `table_name` through `...prev`; saving can target stale
objects in the newly selected database.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45929&comment_hash=8e281268ee61f6d051e15a4dd623fbdd0b848576afe99ad1f1e440086269ebf9&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45929&comment_hash=8e281268ee61f6d051e15a4dd623fbdd0b848576afe99ad1f1e440086269ebf9&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
