mikebridge commented on code in PR #45828:
URL: https://github.com/apache/superset/pull/45828#discussion_r4434020419
##########
superset/mcp_service/chart/chart_helpers.py:
##########
@@ -1165,6 +1165,49 @@ def coerce_enum_values(value: Any) -> Any:
return value
+def _query_semantic_selection_version(
+ form_data: dict[str, Any], extra_form_data: dict[str, Any] | None
+) -> str | None:
+ """Mirror Explore's version transport without certifying external
selections."""
+ version: object = form_data.get("semantic_selection_version")
+ if not isinstance(version, str):
+ return None
+ unverified: str = "unverified-external-selections"
+ sources: list[Any] = list(form_data.get("semantic_selection_sources") or
[])
+ extra: dict[str, Any]
+ for extra in (form_data.get("extra_form_data") or {}, extra_form_data or
{}):
+ if extra.get("semantic_selection_sources"):
Review Comment:
Addressed in `b658756db4438ae584eac4f6fddb17a64409e1d0`: preserve missing
provenance before dashboard/request filters are merged, and check it when
adding filters to saved query contexts too. Unproven or stale contributors stay
unverified; fully versioned inputs still pass, with regression tests for both
merge orders and repeated merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
